Better response variable name db_changed -> report_success
authorKarl O. Pinc <kop@karlpinc.com>
Tue, 16 Jul 2024 12:48:16 +0000 (07:48 -0500)
committerKarl O. Pinc <kop@karlpinc.com>
Tue, 16 Jul 2024 12:48:16 +0000 (07:48 -0500)
src/pgwui_sql/views/sql.py
tests/views/test_sql.py

index 4ed7d65ec19b0e46ade5ebe3fd468b3afdaa63f4..f24eab512296c1bb8c77190b343b7c81f3811c2d 100644 (file)
@@ -46,7 +46,7 @@ def sql_view(request):
     response.setdefault('pgwui', dict())
     response['pgwui']['pgwui_sql'] = settings['pgwui']['pgwui_sql']
 
-    if response['db_changed']:
+    if response['report_success']:
         if pgwui_core.core.is_checked(response['csv_checked']):
             upload_fmt = 'CSV'
         else:
index 974bcecbe5b5f67b7bc252e4cd5ace2ec433040c..f783c1571ac6ba8b52bbf96c8dc5db00b7ef936d 100644 (file)
@@ -46,7 +46,7 @@ DEFAULT_URLS = {'pgwui_sql': '/sql',
 
 CHANGED_RESPONSE = {
     'db': 'somedb',
-    'db_changed': True,
+    'report_success': True,
     'filename': 'file',
     'lines': 5,
     'null_rep': 'NULL',
@@ -56,7 +56,7 @@ CHANGED_RESPONSE = {
     'user': 'someuser',
 }
 
-UNCHANGED_RESPONSE = {'db_changed': False}
+UNCHANGED_RESPONSE = {'report_success': False}
 
 
 # Helper classes
@@ -123,7 +123,7 @@ def test_upload_view_db_not_changed(return_log_tuples):
     assert log_tuples == []
 
 
-def test_upload_view_db_changed_csv(return_log_tuples):
+def test_upload_view_report_success_csv(return_log_tuples):
     '''When the db did change from CSV input something logs'''
     response = CHANGED_RESPONSE
     response['csv_checked'] = constants.CHECKED
@@ -134,7 +134,7 @@ def test_upload_view_db_changed_csv(return_log_tuples):
             == [('pgwui_sql.views.sql', logging.INFO)])
 
 
-def test_upload_view_db_changed_no_csv(return_log_tuples):
+def test_upload_view_report_success_no_csv(return_log_tuples):
     '''When the db did change from not-CSV input something logs'''
     response = CHANGED_RESPONSE
     response['csv_checked'] = constants.UNCHECKED