Abstract out a changed response

diff --git a/tests/views/test_upload.py b/tests/views/test_upload.py
index b1acf6549e8e148dda37fe669ae2b442583fc96c..3cf61afe43169721d541764208070875947cd193 100644 (file)
--- a/tests/views/test_upload.py
+++ b/tests/views/test_upload.py
@@ -24,6 +24,20 @@ from pgwui_core import form_constants
 from pgwui_upload.views import upload
 
 
+# Constants
+CHANGED_RESPONSE = {
+    'db': 'somedb',
+    'db_changed': True,
+    'filename': 'file',
+    'lines': 5,
+    'null_rep': 'NULL',
+    'table': 'sometable',
+    'trim_upload': form_constants.CHECKED,
+    'upload_null': form_constants.CHECKED,
+    'user': 'someuser',
+}
+
+
 # Helper classes
 
 class MockUploadEngine():
@@ -90,21 +104,12 @@ def test_upload_view_db_not_changed(monkeypatch, isolate_upload_view):
     assert mock_logger.info_called is False
 
 
-def test_upload_view_db_changed(monkeypatch, isolate_upload_view):
-    '''When the db did change something logs'''
-
-    response = {
-        'csv_checked': form_constants.CHECKED,
-        'db': 'somedb',
-        'db_changed': True,
-        'filename': 'file',
-        'lines': 5,
-        'null_rep': 'NULL',
-        'table': 'sometable',
-        'trim_upload': form_constants.CHECKED,
-        'upload_null': form_constants.CHECKED,
-        'user': 'someuser',
-    }
+def test_upload_view_db_changed_csv(monkeypatch, isolate_upload_view):
+    '''When the db did change from CSV input something logs'''
+
+    response = CHANGED_RESPONSE
+    response['csv_checked'] = form_constants.CHECKED
+
     mock_logger = isolate_upload_view(response)
     result = upload.upload_view(None)