Better response variable name db_changed -> report_success
authorKarl O. Pinc <kop@karlpinc.com>
Tue, 16 Jul 2024 12:43:45 +0000 (07:43 -0500)
committerKarl O. Pinc <kop@karlpinc.com>
Tue, 16 Jul 2024 12:43:45 +0000 (07:43 -0500)
src/pgwui_copy/templates/copy.mak
src/pgwui_copy/views/copy.py

index 8cc4881ee693ade72e5e68821f52aaa430c79062..dde449b7c37ba415237ea6ccbab724b18ca99c28 100644 (file)
@@ -1,5 +1,5 @@
 <%doc>
-  Copyright (C) 2014, 2015, 2018, 2021 The Meme Factory, Inc.
+  Copyright (C) 2014, 2015, 2018, 2021, 2024 The Meme Factory, Inc.
   http://www.karlpinc.com/
  
      This file is part of PGWUI_Copy.
@@ -26,7 +26,7 @@
     havecreds   Already logged in
     crfs_token
     user
-    db_changed (used by base.mk)
+    report_success (used by base.mk)
 
     schema
     from_db
index ade541442fe873132763ba2f74f8f790f8eb6167..2f2941492b704d88c6c3fa5d05d299111da6433e 100644 (file)
@@ -1,4 +1,4 @@
-# Copyright (C) 2015, 2018, 2020, 2021 The Meme Factory, Inc.
+# Copyright (C) 2015, 2018, 2020, 2021, 2024 The Meme Factory, Inc.
 # http://www.karlpinc.com/
 
 # This file is part of PGWUI_Copy.
@@ -187,13 +187,13 @@ class CopySchemaHandler(SessionDBHandler):
         Returns:
           Dict pyramid will use to render the resulting form
           Reserved keys:
-            errors      A list of UploadError exceptions.
-            db_changed  Boolean. Whether the db was changed.
+            errors          A list of UploadError exceptions.
+            report_success  Boolean. Whether the copy succeeded.
         '''
         response = super().write(result, errors)
 
-        response['db_changed'] = (not response['errors']
-                                  and self.uf['action'] != '')
+        response['report_success'] = (not response['errors']
+                                      and self.uf['action'] != '')
 
         return response
 
@@ -628,7 +628,7 @@ def copy_schema_view(request):
     drop_handler = DropSchemaHandler(request)
     drop_handler.init()
     response, errors = ToDBEngine(drop_handler).run()
-    if response['db_changed']:
+    if response['report_success']:
         # Copy schema to target db.
         try:
             copy_schema(from_handler.uf, settings['pgwui'])
@@ -645,7 +645,7 @@ def copy_schema_view(request):
                             from_handler.uf['schema']),
                         db=markupsafe.escape(from_handler.uf['to_db']))))
             response['errors'].extend(copyerrors)
-            response['db_changed'] = False
+            response['report_success'] = False
         else:
             schema = markupsafe.escape(from_handler.uf['schema'])
             to_db = markupsafe.escape(from_handler.uf['to_db'])