Attach onchange event of upload SQL checkbox with javascript instead of HTML

diff --git a/src/pgwui_sql/static/sql_edit.js b/src/pgwui_sql/static/sql_edit.js
index 9a069b581281c6913d40b38b1b3e346577f9bc3a..6d86a3e0d29d3657dc98024d1dfe4616ff169f3c 100644 (file)
--- a/src/pgwui_sql/static/sql_edit.js
+++ b/src/pgwui_sql/static/sql_edit.js
@@ -37,9 +37,10 @@ function showSearchPath() {
         window.alert('Problem showing the search_path: ' + error);
         })
 };
-function toggleSqlUsed(elem) {
+
+function toggleSqlUsed() {
   sql_text = document.getElementById('sql_id');
-  if (elem.checked) {
+  if (this.checked) {
     sql_text.style.backgroundColor = '#ececec';
   } else {
     sql_text.style.backgroundColor = '';
@@ -83,6 +84,10 @@ function attachEvents() {
     expand_eol_info.addEventListener("keydown", toggleEOLInfoRow);
     collapse_eol_info.addEventListener("keydown", toggleEOLInfoRow);
 
+    /* Upload SQL selection */
+    document.getElementById('upload_sql_id')
+        .addEventListener("change", toggleSqlUsed);
+
     /* Tab-delimited help */
     document.getElementById('tab_delimited_help_id')
         .addEventListener("click", () =>

diff --git a/src/pgwui_sql/templates/sql_edit.mak b/src/pgwui_sql/templates/sql_edit.mak
index 44137c5c12723a5a715d20b038d60b831c8591bb..d876e8acd3cd52dda956d4cdec3a8e3d5c7c39d6 100644 (file)
--- a/src/pgwui_sql/templates/sql_edit.mak
+++ b/src/pgwui_sql/templates/sql_edit.mak
@@ -127,7 +127,6 @@
                  tabindex="${tab_index.val}"
                  id="upload_sql_id"
                  type="checkbox"
-                 onchange="toggleSqlUsed(this);"
                  ${upload_sql}
                  />
         </%self.lib:td_input>