Better response variable name db_changed -> report_success
authorKarl O. Pinc <kop@karlpinc.com>
Tue, 16 Jul 2024 12:51:33 +0000 (07:51 -0500)
committerKarl O. Pinc <kop@karlpinc.com>
Tue, 16 Jul 2024 12:51:33 +0000 (07:51 -0500)
src/pgwui_upload/views/upload.py
tests/views/test_upload.py

index e5cb7f4d4406b8057b0d8b796bf60b8ccf87bfd5..36f195dbc121fae2ea3200edd3472f66b0d11ed0 100644 (file)
@@ -186,6 +186,6 @@ def upload_view(request):
 
     set_upload_response('pgwui_upload', request, response)
 
-    if response['db_changed']:
+    if response['report_success']:
         log_success(response)
     return response
index 846777074f1d14f5881facf3d081f539082b54d9..2052e2dadd5b8e4f7553e7ed02e3c6d98802178c 100644 (file)
@@ -37,7 +37,7 @@ pytest_plugins = ("pgwui",)
 # Constants
 CHANGED_RESPONSE = {
     'db': 'somedb',
-    'db_changed': True,
+    'report_success': True,
     'filename': 'file',
     'lines': 5,
     'null_rep': 'NULL',
@@ -47,7 +47,7 @@ CHANGED_RESPONSE = {
     'user': 'someuser',
 }
 
-UNCHANGED_RESPONSE = {'db_changed': False}
+UNCHANGED_RESPONSE = {'report_success': False}
 
 # A "upload form"
 UPLOAD_FORM_W_LIT_CHECKED = {'literal_col_headings': True}
@@ -184,7 +184,7 @@ def test_upload_view_db_not_changed(undecorate, mock_log_success):
     assert mock_log_success.call_count == 0
 
 
-def test_upload_view_db_changed(undecorate, mock_log_success):
+def test_upload_view_report_success(undecorate, mock_log_success):
     '''When the db did change from CSV input log_success() is called'''
     response = CHANGED_RESPONSE
     result = undecorate(response)